Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 82894 invoked from network); 7 Sep 2009 17:57:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 7 Sep 2009 17:57:23 -0000 Received: (qmail 3257 invoked by uid 500); 7 Sep 2009 17:57:22 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 3141 invoked by uid 500); 7 Sep 2009 17:57:22 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 3131 invoked by uid 99); 7 Sep 2009 17:57:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2009 17:57:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2009 17:57:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 634C6234C4A9 for ; Mon, 7 Sep 2009 10:56:58 -0700 (PDT) Message-ID: <780226556.1252346218403.JavaMail.jira@brutus> Date: Mon, 7 Sep 2009 10:56:58 -0700 (PDT) From: "Henri Yandell (JIRA)" To: issues@commons.apache.org Subject: [jira] Closed: (LANG-481) Possible race-conditions in hashCode of the range classes In-Reply-To: <257814446.1232740199743.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell closed LANG-481. ------------------------------ Resolution: Fixed Patch applied - thanks Boris :) > Possible race-conditions in hashCode of the range classes > --------------------------------------------------------- > > Key: LANG-481 > URL: https://issues.apache.org/jira/browse/LANG-481 > Project: Commons Lang > Issue Type: Bug > Affects Versions: 2.4 > Reporter: Boris > Priority: Minor > Fix For: 3.0 > > Attachments: LANG-481.patch > > > The hashCode() methods of the range classes look very suspicious to me. The value is lazily initialized, but the calculation is done _on the cached value. With some unlucky timing a caller may get an incomplete hash. > An unlucky sequence of Code could be something like > T1: if (hashCode == 0) // true > T1: hashCode = 17; > T2: if (hashCode == 0) // now false because hashCode was already set to 17 > T2: return hashCode; // return 17 > T1: hashCode = 37 * hashCode........... > where T1 and T2 are different threads accessing the method in parallel and T2 gets the wrong hash "17". > Affected classes are > org.apache.commons.lang.math.DoubleRange > org.apache.commons.lang.math.FloatRange > org.apache.commons.lang.math.IntRange > org.apache.commons.lang.math.LongRange > org.apache.commons.lang.math.NumberRange > org.apache.commons.lang.math.Range > Possible fix: calculate the hash on a temporary variable and finally assign it to the member -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.