Return-Path: 
 <issues-return-10044-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: (qmail 52126 invoked from network); 23 Sep 2009 15:58:41 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 23 Sep 2009 15:58:41 -0000
Received: (qmail 36252 invoked by uid 500); 23 Sep 2009 15:58:40 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 36086 invoked by uid 500); 23 Sep 2009 15:58:39 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 36074 invoked by uid 99); 23 Sep 2009 15:58:39 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2009 15:58:39 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2009 15:58:36 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 1035E234C4A9
	for <issues@commons.apache.org>; Wed, 23 Sep 2009 08:58:16 -0700 (PDT)
Message-ID: <1700029765.1253721496065.JavaMail.jira@brutus>
Date: Wed, 23 Sep 2009 08:58:16 -0700 (PDT)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (LANG-534) ArrayUtils should have method to convert
 null arrays to empty ones to help with Defensive coding
In-Reply-To: <904928838.1253516777914.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/LANG-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-534:
-------------------------------

    Remaining Estimate:     (was: 0.17h)
     Original Estimate:     (was: 0.17h)

> ArrayUtils should have method to convert null arrays to empty ones to help with Defensive coding
> ------------------------------------------------------------------------------------------------
>
>                 Key: LANG-534
>                 URL: https://issues.apache.org/jira/browse/LANG-534
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Levon Karayan
>            Priority: Trivial
>         Attachments: 20090920LevonArrayUtils-nullToEmpty.patch
>
>
> There are APIs that I've come across that return <code>null</code> Arrays in the event where there are no results.  Often these APIs correctly throw exceptions when there is an "exceptional event", but no results isn't exceptional, and it often shouldn't be.   This causes the programmer to make extra tests for null throughout the code to deal with the null case, and sometimes these null cases are added after a customer searched for gobleygook and got a NullPointerException.  It's just far cleaner/safer to convert these null arrays to empty arrays.
> Another benefit to this method is that if the array being passed in is actually already an empty array, it will swap the pointer for the <code>static final</code> in the ArrayUtils class to help decrease memory fragmentation.
> e.g.
> BEFORE:
> try
> {
>   results = customer.getResults(query);
> } catch ( IOException ioex ) {
>   //  ...
> }
> if ( null == results )
> {
>    results = new int[0]{};
> }
> // do stuff
> AFTER
> try
> {
>   results = ArrayUtils.nullToEmpty(customer.getResults(query));
> } catch ( IOException ioex ) {
>   //  ...
> }
> // do stuff

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.