Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1690706966.1251967836713.JavaMail.jira@brutus>
Date: Thu, 3 Sep 2009 01:50:36 -0700 (PDT)
From: "Henri Biestro (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Issue Comment Edited: (JEXL-44) Comments don't allow
 double-quotes
In-Reply-To: <124347252.1210682455580.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JEXL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750814#action_12750814 ] 

Henri Biestro edited comment on JEXL-44 at 9/3/09 1:50 AM:
-----------------------------------------------------------

As for why the behavior is not (yet) the same, the ## was left as is because it looked like a Velocity legacy; the // was added to fix the original issue with no disruption.
If we are to change the behavior, may be having only one syntax for single-line comment (the //) would be clearer ?

Btw,
URL: http://svn.apache.org/viewvc?rev=810815&view=rev
Log: 
Allow single line comment // to end on EOF; add test 

Modified: 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt 
    commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java 


      was (Author: henrib):
    As for why the behavior is not (yet) the same, the ## was left as is because it looked like a Velocity legacy; the // was added to fix the original issue with no disruption.
If we are to change the behavior, may be having only one syntax for single-line comment (the //) would be clearer ?


> Comments don't allow double-quotes
> ----------------------------------
>
>                 Key: JEXL-44
>                 URL: https://issues.apache.org/jira/browse/JEXL-44
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Sebb
>             Fix For: 2.0
>
>
> Comment lines should allow any characters; however for some reason double-quotes are not allowed.
> Single quotes are OK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.