commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (COLLECTIONS-255) Unused variable in TreeBidiMap.java
Date Tue, 15 Sep 2009 06:02:02 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell reopened COLLECTIONS-255:
---------------------------------------


During the merge of the generics branch, I had to revert this fix. It needs to be refactored/reapplied
in the new generics modified code.

> Unused variable in TreeBidiMap.java
> -----------------------------------
>
>                 Key: COLLECTIONS-255
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-255
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: BidiMap
>    Affects Versions: Nightly Builds
>            Reporter: Henri Yandell
>            Assignee: Henri Yandell
>            Priority: Trivial
>             Fix For: 3.3
>
>         Attachments: COLLECTIONS-255.patch
>
>
> Twice in TreeBidiMap there is an entrySet variable that is not used. Rather the entrySet()
method returns a new TreeView every time.
> We should either:
> a) Delete the variable.
> b) Use the variable and always return the same TreeView.
> I'm thinking a).
> [Found via http://opensource.fortifysoftware.com/ ]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message