commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "VIJAY KUMAR (JIRA)" <j...@apache.org>
Subject [jira] Created: (POOL-150) GenericKeyedObjectPool.preparePool does not throw an exception if supplied factory is null
Date Wed, 16 Sep 2009 12:46:57 GMT
GenericKeyedObjectPool.preparePool does not throw an exception if supplied factory is null
------------------------------------------------------------------------------------------

                 Key: POOL-150
                 URL: https://issues.apache.org/jira/browse/POOL-150
             Project: Commons Pool
          Issue Type: Bug
    Affects Versions: 1.4
         Environment: Java 5
            Reporter: VIJAY KUMAR


GenericKeyedObjectPool.preparePool  doesnot throw an exception if supplied factory is null.


GenericKeyedObjectPool.preparePool invokes ensureMinIdle() if populateImmediately is true
and GenericKeyedObjectPool.ensureMinIdle() invokes GenericKeyedObjectPool.addObject() which
throws an IllegalStateException if factory is null but this exception does not throw further
in GenericKeyedObjectPool.preparePool.

Catch block of  GenericKeyedObjectPool..preparePool is empty.

public synchronized void preparePool(Object key, boolean populateImmediately) {
    	ObjectQueue pool = (ObjectQueue)(_poolMap.get(key));
    	System.out.println(this.getClass().getName()+".preparePool() pool  ["+pool +"]");
        if (null == pool) {
            pool = new ObjectQueue();
            _poolMap.put(key,pool);
            _poolList.add(key);
        }

        if (populateImmediately) {
            try {
                // Create the pooled objects
            	System.out.println(this.getClass().getName()+".preparePool() Create the pooled
objects ");
                ensureMinIdle(key);
            }
            catch (Exception e) {
                //Do nothing
            }
        }
    }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message