Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 92220 invoked from network); 3 Aug 2009 11:15:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Aug 2009 11:15:35 -0000 Received: (qmail 28777 invoked by uid 500); 3 Aug 2009 11:15:39 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 28678 invoked by uid 500); 3 Aug 2009 11:15:39 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 28668 invoked by uid 99); 3 Aug 2009 11:15:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 11:15:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 11:15:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3A067234C1E6 for ; Mon, 3 Aug 2009 04:15:15 -0700 (PDT) Message-ID: <509728833.1249298115236.JavaMail.jira@brutus> Date: Mon, 3 Aug 2009 04:15:15 -0700 (PDT) From: "Niall Pemberton (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (CODEC-55) make all "business" method implementations of public API thread safe In-Reply-To: <26896886.1191789710570.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CODEC-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated CODEC-55: --------------------------------- Attachment: CODEC-55-Wrapper-Implementations.patch An alternative solution is to provide wrappers that only expose the Encoder/Decoder methods. Attaching CODEC-55-Wrapper-Implementations.patch which contains: * StringEncoderWrapper - wrapper for StringEncoder implementations - can be used to resolve DoubleMetaphone, Metaphone, RefinedSoundex and Soundex thread safety issues * StringCodecWrapper - wrapper for StringEncoder and StringDecoder implementations - can be used to resolve QCodec thread safety issue (making charset final has already been committed). The other issue was with the protected fields in URLCodec - changing them to final would break binary compatibility but also its less of an issue IMO since URLCodec used directly will not have an issue as those fields are not exposed - its only implementations that extend from URLCodec that could have problems. > make all "business" method implementations of public API thread safe > --------------------------------------------------------------------- > > Key: CODEC-55 > URL: https://issues.apache.org/jira/browse/CODEC-55 > Project: Commons Codec > Issue Type: Wish > Reporter: Qingtian Wang > Attachments: CODEC-55-Wrapper-Implementations.patch, concurrentCodecs.diff, concurrentQDiff.diff, urlcodec.patch > > > Maybe most of the implementations are already thread safe. Just such that codec can say so in general... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.