Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 82319 invoked from network); 11 Aug 2009 06:46:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Aug 2009 06:46:32 -0000 Received: (qmail 59720 invoked by uid 500); 11 Aug 2009 06:46:39 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 59620 invoked by uid 500); 11 Aug 2009 06:46:39 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 59610 invoked by uid 99); 11 Aug 2009 06:46:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2009 06:46:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2009 06:46:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C7493234C004 for ; Mon, 10 Aug 2009 23:46:14 -0700 (PDT) Message-ID: <373074789.1249973174801.JavaMail.jira@brutus> Date: Mon, 10 Aug 2009 23:46:14 -0700 (PDT) From: "Henri Yandell (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (LANG-494) CharSet sub-classes cannot be made thread-safe In-Reply-To: <1110150131.1237130810436.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741723#action_12741723 ] Henri Yandell commented on LANG-494: ------------------------------------ So, do we wrap it in a synchronized call? > CharSet sub-classes cannot be made thread-safe > ---------------------------------------------- > > Key: LANG-494 > URL: https://issues.apache.org/jira/browse/LANG-494 > Project: Commons Lang > Issue Type: Bug > Reporter: Sebb > Fix For: 3.0 > > > AFAICT, CharSet sub-classes cannot be made thread-safe. > This is because the HashMap and HashSet collections are not thread-safe. > If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update. > In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.