Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 15077 invoked from network); 1 Aug 2009 20:28:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Aug 2009 20:28:34 -0000 Received: (qmail 95134 invoked by uid 500); 1 Aug 2009 20:28:37 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 95017 invoked by uid 500); 1 Aug 2009 20:28:37 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 95007 invoked by uid 99); 1 Aug 2009 20:28:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2009 20:28:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2009 20:28:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C9C74234C004 for ; Sat, 1 Aug 2009 13:28:14 -0700 (PDT) Message-ID: <354001135.1249158494812.JavaMail.jira@brutus> Date: Sat, 1 Aug 2009 13:28:14 -0700 (PDT) From: "Aleksey Shipilev (JIRA)" To: issues@commons.apache.org Subject: [jira] Closed: (COMPRESS-83) GzipCompressorOutputStream should forward write(byte[] buf) and write(byte[] buf, int off, int len) to underlying stream In-Reply-To: <748191386.1248960074853.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COMPRESS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Shipilev closed COMPRESS-83. ------------------------------------ Agree with the commit, closing the issue. > GzipCompressorOutputStream should forward write(byte[] buf) and write(byte[] buf, int off, int len) to underlying stream > ------------------------------------------------------------------------------------------------------------------------ > > Key: COMPRESS-83 > URL: https://issues.apache.org/jira/browse/COMPRESS-83 > Project: Commons Compress > Issue Type: Improvement > Affects Versions: 1.0 > Environment: Linux > Reporter: Aleksey Shipilev > Fix For: 1.1 > > Original Estimate: 1h > Remaining Estimate: 1h > > Current version of GzipCompressorOutputStream decorates only write(int b) method for underlying java.zip.util.GZipOutputStream. > In common scenario of: > OutputStream os = ...; > GzipCompressorOutputStream gcos = new GzipCompressorOutputStream(os); > [do extensive write(byte[] buf] > this results in very slow _unbuffered_ write. This is particularly evident if the code changes to: > OutputStream os = ...; > GZIPOutputStream gos = new GZIPOutputStream(os); > [do extensive write(byte[] buf] > ...which is blazingly faster. > In my environment, packing 100 Mb stream with Commons wrapper takes about 120 seconds, while using java.util.zip directly takes less than 1 second. > This performance hit is way too bad for simple wrapper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.