Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 21448 invoked from network); 14 Aug 2009 19:48:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Aug 2009 19:48:33 -0000 Received: (qmail 63646 invoked by uid 500); 14 Aug 2009 19:48:39 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 63537 invoked by uid 500); 14 Aug 2009 19:48:39 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 63518 invoked by uid 99); 14 Aug 2009 19:48:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2009 19:48:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2009 19:48:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C776C234C004 for ; Fri, 14 Aug 2009 12:48:14 -0700 (PDT) Message-ID: <329849764.1250279294802.JavaMail.jira@brutus> Date: Fri, 14 Aug 2009 12:48:14 -0700 (PDT) From: "Henri Biestro (JIRA)" To: issues@commons.apache.org Subject: [jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches In-Reply-To: <1640188003.1250270354896.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743392#action_12743392 ] Henri Biestro edited comment on JEXL-85 at 8/14/09 12:46 PM: ------------------------------------------------------------- StatementExpression are no longer creating objects (they are #void in the Parser.jjt). Thus there is one child level that does not exist anymore. The JexlEngine.{s,g}etProperty methods where the change occur are checked through the AssignTest.java. was (Author: henrib): StatementExpression are no longer creating objects (they are #void in the Parser.jjt). Thus there is one child level that does not exist anymore. The {s,g}etProperty are checked through the AssignTest.java. > 2.0 grammar finishing touches > ----------------------------- > > Key: JEXL-85 > URL: https://issues.apache.org/jira/browse/JEXL-85 > Project: Commons JEXL > Issue Type: Improvement > Reporter: Henri Biestro > Fix For: 2.0 > > Attachments: JEXL-85.patch > > > The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option). > Tthe {Expression,Statement,Reference}Expression dont need to create real nodes. > There are a few places where the LOOKAHEAD can be reduced or more explicit. > Some expressions (Reference) are really hard to read partly due to formatting. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.