Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1953500379.1251565653213.JavaMail.jira@brutus>
Date: Sat, 29 Aug 2009 10:07:33 -0700 (PDT)
From: "Henri Biestro (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
 debugger update
In-Reply-To: <1640188003.1250270354896.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ] 

Henri Biestro commented on JEXL-85:
-----------------------------------

URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log: 
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL 

Modified: 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java 
    commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java 
    commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java

URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log: 
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional. 
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts. 
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode. 
Debugger.java: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86). 
JexlEngine.java: modified because StatementExpression are no longer creating nodes (#void) 

Modified: 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt 

> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
>                 Key: JEXL-85
>                 URL: https://issues.apache.org/jira/browse/JEXL-85
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>
>         Attachments: JEXL-85.patch, JEXL-85.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.