Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1703763865.1250765954814.JavaMail.jira@brutus>
Date: Thu, 20 Aug 2009 03:59:14 -0700 (PDT)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
 debugger update
In-Reply-To: <1640188003.1250270354896.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745389#action_12745389 ] 

Sebb commented on JEXL-85:
--------------------------

Sorry, but I think there are far too many changes in the patch.

It's really difficult to follow the patch, and it will be difficult to follow the SVN history.

I think the patch needs to be broken down into more manageable chunks.

Also, there needs to be a vote on whether it makes sense to change the behaviour of an Expression so that it behaves like a Script.

> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
>                 Key: JEXL-85
>                 URL: https://issues.apache.org/jira/browse/JEXL-85
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>
>         Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.