Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 99435 invoked from network); 3 Aug 2009 21:03:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Aug 2009 21:03:34 -0000 Received: (qmail 72167 invoked by uid 500); 3 Aug 2009 21:03:39 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 72063 invoked by uid 500); 3 Aug 2009 21:03:39 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 72053 invoked by uid 99); 3 Aug 2009 21:03:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 21:03:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 21:03:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E47B3234C053 for ; Mon, 3 Aug 2009 14:03:14 -0700 (PDT) Message-ID: <1179120858.1249333394935.JavaMail.jira@brutus> Date: Mon, 3 Aug 2009 14:03:14 -0700 (PDT) From: "Henri Biestro (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (JEXL-67) Potential NPE in util.introspection.MethodKey In-Reply-To: <2089125636.1249220114848.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JEXL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-67: ------------------------------ Attachment: JEXL-67.patch removed the MethodMap.AmbiguousException, replaced by MethodKey.AmbiguousException > Potential NPE in util.introspection.MethodKey > --------------------------------------------- > > Key: JEXL-67 > URL: https://issues.apache.org/jira/browse/JEXL-67 > Project: Commons JEXL > Issue Type: Bug > Reporter: Sebb > Priority: Minor > Fix For: 2.0 > > Attachments: JEXL-67.patch, JEXL-67.patch > > > There are two potential NPEs in util.introspection.MethodKey (discovered by Eclipse) > isInvocationConvertible > isStrictInvocationConvertible > Both methods check for actual == null, but the check is part of a compound and condition so actual may still be null. > The comments suggest that actual should not be null, so the code should either drop the null check entirely or check it properly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.