commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JEXL-83) Make JexlArithmetic immutable (and threadsafe)
Date Sun, 30 Aug 2009 13:55:32 GMT

    [ https://issues.apache.org/jira/browse/JEXL-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749257#action_12749257
] 

Henri Biestro commented on JEXL-83:
-----------------------------------


URL: http://svn.apache.org/viewvc?rev=809337&view=rev
Log: 
Document setSilent/setDebug/setLenient/setFunctions methods as non-thread-safe 

Modified: 
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlArithmetic.java

    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java


> Make JexlArithmetic immutable (and threadsafe)
> ----------------------------------------------
>
>                 Key: JEXL-83
>                 URL: https://issues.apache.org/jira/browse/JEXL-83
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: Later
>
>         Attachments: JEXL-83.patch
>
>
> The JexlArithmetic class is currently not thread-safe because of the single field:
>     /** Whether this JexlArithmetic instance behaves in strict or lenient mode. */
>     protected boolean strict;
> If this field were made final, and the setLenient() method removed, then the class would
be immutable and therefore thread-safe.
> This would mean that JexlEngine would also have to change.
> The class is new to 2.0, so this is the best time to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message