commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Akolkar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JEXL-67) Potential NPE in util.introspection.MethodKey
Date Mon, 03 Aug 2009 20:47:14 GMT

    [ https://issues.apache.org/jira/browse/JEXL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738576#action_12738576
] 

Rahul Akolkar commented on JEXL-67:
-----------------------------------

No comments on the patch (haven't looked at it). I probably won't be looking at it this week
either.


> Potential NPE in util.introspection.MethodKey
> ---------------------------------------------
>
>                 Key: JEXL-67
>                 URL: https://issues.apache.org/jira/browse/JEXL-67
>             Project: Commons JEXL
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: JEXL-67.patch
>
>
> There are two potential NPEs in util.introspection.MethodKey (discovered by Eclipse)
> isInvocationConvertible
> isStrictInvocationConvertible
> Both methods check for actual == null, but the check is part of a compound and condition
so actual may still be null.
> The comments suggest that actual should not be null, so the code should either drop the
null check entirely or check it properly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message