commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger update
Date Thu, 20 Aug 2009 10:33:14 GMT

     [ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Biestro updated JEXL-85:
------------------------------

    Attachment: JEXL-85.patch

Re-added statement requirement for 'for','while', 'if/else' ( the 'while(false) while(false)'
case ) since this was indeed too lax. (EmptyStatement aka ';' is sufficient).

Added Java Unicode escape sequence in parse (through StringParser).
Removed the difference between Script & Expression (svn del ScriptImpl.java); can't see
any need for the functional difference - it could only generate warnings - and the only parsing
entry point was anyway generating ASTJexlScript.
Kept the Script interface as a convenience allowing to import another package Expression.

As for the grammar reordering, although I understand the inconvenience this creates to review
the changes, it radically improves reading / following / maintaining the grammar Statement
are now logically grouped instead of being spread accross the file.
(Having spent  quite a few hours on it, this makes a huge difference) 

All tests pass, no regressions.

> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
>                 Key: JEXL-85
>                 URL: https://issues.apache.org/jira/browse/JEXL-85
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>
>         Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field,
NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message