commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <>
Subject [jira] Updated: (JEXL-83) Make JexlArithmetic immutable (and threadsafe)
Date Sun, 16 Aug 2009 05:13:14 GMT


Henri Biestro updated JEXL-83:

    Attachment: JEXL-83.patch

Added comments to JexlEngine#set{Lenient,Silent,Debug} and to JexlArithmetic#setLenient stating
these are not thread-safe and should be optional steps of the JexlEngine intialization code.
Made JexlArithmetic#setLenien package protected to force calls through JexlEngine.

> Make JexlArithmetic immutable (and threadsafe)
> ----------------------------------------------
>                 Key: JEXL-83
>                 URL:
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: Later
>         Attachments: JEXL-83.patch
> The JexlArithmetic class is currently not thread-safe because of the single field:
>     /** Whether this JexlArithmetic instance behaves in strict or lenient mode. */
>     protected boolean strict;
> If this field were made final, and the setLenient() method removed, then the class would
be immutable and therefore thread-safe.
> This would mean that JexlEngine would also have to change.
> The class is new to 2.0, so this is the best time to fix this.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message