commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LANG-474) Fixes for thread safety
Date Tue, 11 Aug 2009 06:38:15 GMT

    [ https://issues.apache.org/jira/browse/LANG-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741717#action_12741717
] 

Henri Yandell edited comment on LANG-474 at 8/10/09 11:37 PM:
--------------------------------------------------------------

Most of the above is gone. The following is still open:

The following fields could be made final:

org.apache.commons.lang.text.StrMatcher - class variables in nested classes could be made
final

These have already been made final:

org.apache.commons.lang.text.ExtendedMessageFormat.registry
org.apache.commons.lang.CharSet.set

      was (Author: bayard):
    Most of the above is gone. The following is still open:

The following fields could be made final:
org.apache.commons.lang.text.ExtendedMessageFormat.registry
org.apache.commons.lang.text.StrMatcher - class variables in nested classes could be made
final
org.apache.commons.lang.CharSet.set
  
> Fixes for thread safety
> -----------------------
>
>                 Key: LANG-474
>                 URL: https://issues.apache.org/jira/browse/LANG-474
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.0
>
>
> org.apache.commons.lang.exception.NestableDelegate
> - the static boolean fields should probably be made volatile to ensure that they are
visible across threads
> If not, the Javadoc should be updated to note that changing the setting renders the class
not thread-safe.
> - the "nestable" field should be declared final
> org.apache.commons.lang.exception.NestableError / NestableRuntimeException / NestableException
> - Fields "cause" and "delegate" should be made final to improve thread-safety
> The following fields could be made final:
> org.apache.commons.lang.text.ExtendedMessageFormat.registry
> org.apache.commons.lang.text.StrMatcher - class variables in nested classes could be
made final
> org.apache.commons.lang.CharSet.set
> Also:
> org.apache.commons.lang.IntHashMap.Entry - the field "key" is never used

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message