commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JEXL-85) 2.0 grammar finishing touches
Date Fri, 14 Aug 2009 19:22:14 GMT

    [ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743374#action_12743374
] 

Sebb commented on JEXL-85:
--------------------------

There are two instances of the following change in JexlEngine:

-            JexlNode node = tree.jjtGetChild(0).jjtGetChild(0);
+            JexlNode node = tree.jjtGetChild(0);

Not sure how that relates to the Parser changes mentioned in the Description.

> 2.0 grammar finishing touches
> -----------------------------
>
>                 Key: JEXL-85
>                 URL: https://issues.apache.org/jira/browse/JEXL-85
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>
>         Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field,
NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message