commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <>
Subject [jira] Commented: (JEXL-85) 2.0 grammar finishing touches & debugger update
Date Thu, 20 Aug 2009 11:57:14 GMT


Henri Biestro commented on JEXL-85:

I'm still surprised when contributing ends up being such an unpleasant & dry experience...

The only thing that makes an Expression not behave like a Script is a warning; do you have
any functional need for this warning yourself ?

Besides, knowing this wont change anything, creating 5 patches versus 5 commits is very different
in time consumption; it will ultimately allow the same level of change tracking and all of
them relate to changes in the grammar.
** : allow Unicode escape sequence \uxxxx .
*Parser.jjt /* : changes statement to avoid the need for ';' at end - make
grammar readable .
** : reflect changes in grammar for statements .
*** : test Debugger, verify it can roundtrip all expressions in tests .
*,* change, ** removal : simplify code,
remove dubious warning .

Thanks so much for your help and trust...

> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>                 Key: JEXL-85
>                 URL:
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>         Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field,
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message