commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] Commented: (JEXL-85) 2.0 grammar finishing touches & debugger update
Date Wed, 19 Aug 2009 18:50:14 GMT


Sebb commented on JEXL-85:

I'm not sure about the way the trailing ';' has been eliminated in the grammar. It's difficult
to see where ';' is required.

In fact I think there's a problem, as the following is allowed:

   while (false) while (false)

I think it should insist on a ';' between the statements.

It's also really difficult to follow the grammar changes as some of the sections seem to have
been re-ordered.

> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>                 Key: JEXL-85
>                 URL:
>             Project: Commons JEXL
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>             Fix For: 2.0
>         Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field,
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message