commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <>
Subject [jira] Issue Comment Edited: (JEXL-67) Potential NPE in util.introspection.MethodKey
Date Sun, 02 Aug 2009 18:45:14 GMT


Henri Biestro edited comment on JEXL-67 at 8/2/09 11:44 AM:

refactored MethodKey attempting to remove ambiguity wrt null checks.
Findbugs - the Maven plugin version - does not see those neither does Netbeans.
Did not find (yet) a way to use Eclipse on an existing pom.xml (on Mac); any hint ?

      was (Author: henrib):
    refactored MethodKey to remove ambiguity wrt null checks 
> Potential NPE in util.introspection.MethodKey
> ---------------------------------------------
>                 Key: JEXL-67
>                 URL:
>             Project: Commons JEXL
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.0
>         Attachments: JEXL-67.patch
> There are two potential NPEs in util.introspection.MethodKey (discovered by Eclipse)
> isInvocationConvertible
> isStrictInvocationConvertible
> Both methods check for actual == null, but the check is part of a compound and condition
so actual may still be null.
> The comments suggest that actual should not be null, so the code should either drop the
null check entirely or check it properly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message