Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 99924 invoked from network); 15 Jul 2009 03:55:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Jul 2009 03:55:31 -0000 Received: (qmail 19988 invoked by uid 500); 15 Jul 2009 03:55:40 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 19803 invoked by uid 500); 15 Jul 2009 03:55:39 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 19774 invoked by uid 99); 15 Jul 2009 03:55:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2009 03:55:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2009 03:55:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C78F5234C004 for ; Tue, 14 Jul 2009 20:55:14 -0700 (PDT) Message-ID: <2044184208.1247630114802.JavaMail.jira@brutus> Date: Tue, 14 Jul 2009 20:55:14 -0700 (PDT) From: "Rahul Akolkar (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (JEXL-58) UnifiedJEXL In-Reply-To: <1502369221.1247520795591.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JEXL-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Akolkar updated JEXL-58: ------------------------------ Assignee: Rahul Akolkar I've committed the patch to the 2.0 branch in r794133, it'd be great if you could double check: http://svn.apache.org/viewvc?view=rev&revision=794133 Thanks for the contribution. Some follow-up comments (so leaving this issue unresolved): * I like that the 1.0 line uses a checked exception from Expression#evaluate(...) -- this ensures that users actually think about how JEXL clients should cope when expression evaluation blows up. I see that the change was part of JEXL-55 when JexlException was added (as a RuntimeException). Fine with using a narrower class here (though we should ask if it is really worth the signature change to a core API) but I'd prefer to keep it as a checked exception. * There are some traces to console when running the tests, best to avoid that IMO (by handling those exceptions in test code). > UnifiedJEXL > ----------- > > Key: JEXL-58 > URL: https://issues.apache.org/jira/browse/JEXL-58 > Project: Commons JEXL > Issue Type: New Feature > Reporter: Henri Biestro > Assignee: Rahul Akolkar > Fix For: 2.0 > > Attachments: JEXL-58.patch, JEXL-58.patch, JEXL-58.patch > > > An evaluator similar to the unified EL evaluator used in JSP/JSF based on JEXL. > It is intended to be used in configuration modules, XML based frameworks or JSP taglibs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.