Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1213333226.1248647654812.JavaMail.jira@brutus>
Date: Sun, 26 Jul 2009 15:34:14 -0700 (PDT)
From: "Julius Davies (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (CODEC-81) Base64's new constructor parameters
 ignored
In-Reply-To: <2104021657.1248647174782.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julius Davies updated CODEC-81:
-------------------------------

    Attachment: codec81-fix.patch
                codec81-junit.patch

Two patches attached:

1. codec81-junit.patch  highlights the bug.
2. codec81-fix.patch      fixes the bug.

There's a tiny bit of code cleanup in there anticipating my next attempt at a CODEC-59 patch - in particular this, since hopefully "instanceof String" will become a valid Object type to decode.

{code}
-         if (!(pObject instanceof byte[])) {
+        if (pObject instanceof byte[]) {
+            return decode((byte[]) pObject);
+        } else {
             throw new DecoderException("Parameter supplied to Base64 decode is not a byte[]");
          }
{code}


> Base64's new constructor parameters ignored
> -------------------------------------------
>
>                 Key: CODEC-81
>                 URL: https://issues.apache.org/jira/browse/CODEC-81
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Julius Davies
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: codec81-fix.patch, codec81-junit.patch
>
>
> Base64's new constructor parameters are ignored (e.g. chunkSize and chunkSeparator) when using the Encoder interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.