commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ales Dolecek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SCXML-109) Attribute targettype of send and invoke elements changed to type in SCXML Working Draft (7 May 2009)
Date Tue, 14 Jul 2009 16:55:14 GMT

    [ https://issues.apache.org/jira/browse/SCXML-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730971#action_12730971
] 

Ales Dolecek commented on SCXML-109:
------------------------------------

There are other places where "targettype" remains in the sources. 

* EventDispatcher interface and it's 2 implementations - SimpleDispatcher and SimpleScheduler:
just comments and names of method parameters and local variables
* Invoker - just comments
* SCInstance - comments and names of parameters/variables
* SCXMLExecutor - names of parameters

The XML files and serialization test use old attribute:
Note: SCXMLSerializerTest#testSerializeSend() will fail if patch3.txt gets applied (there
is no such test for invoke)

Finally documentation should be updated as well.

I can create patch for all of the above as well. Just let me know if the serialization should
be patched or not.

Ales


> Attribute targettype of send and invoke elements changed to type in SCXML Working Draft
(7 May 2009)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SCXML-109
>                 URL: https://issues.apache.org/jira/browse/SCXML-109
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Ales Dolecek
>            Priority: Minor
>             Fix For: 0.10, 1.0
>
>         Attachments: patch.txt, patch2.txt, patch3.txt
>
>
> Latest SCXML working draft use attribute type instead of targettype.
> => Rename (refactor) property targettype to type
> => Deprecate String getTargettype() and void setTargettype(String)
> => Add getter/setter for new property

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message