commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (JEXL-35) Final API requirements
Date Wed, 22 Jul 2009 02:34:14 GMT

    [ https://issues.apache.org/jira/browse/JEXL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733954#action_12733954
] 

Henri Biestro edited comment on JEXL-35 at 7/21/09 7:34 PM:
------------------------------------------------------------

I went ahead and refactored the o.a.c.jexl.util & o.a.c.jexl.util.introspection. (removed
some classes that were not used and moved the usefull code in util.introspector; added test
to improve coverage).
The idea was to keep the packages & keep sense; thus, the util.Introspector has been beefed
up with "high level" property set/get per-type and the Uberspect deals with finding the most
appropriate executors.
It's probably a tad slower than the previous code (what used to be in the Interpreter) but
"clearer" in what is performed (imho of course :-) ).
Let me know if I should continue on this route or if this is really too big of a change (I
will still have to go redo a bit of JEXL-20).


      was (Author: henrib):
    I went ahead and refactored the o.a.c.jexl.util & o.a.c.jexl.util.introspection.
The idea was to keep the packages & keep sense; thus, the util.Introspector has been beefed
up with "high level" property set/get per-type and the Uberspect deals with finding the most
appropriate executors.
It's probably a tad slower than the previous code (what used to be in the Interpreter) but
"clearer" in what is performed (imho of course :-) ).
Let me know if I should continue on this route or if this is really too big of a change.

  
> Final API requirements
> ----------------------
>
>                 Key: JEXL-35
>                 URL: https://issues.apache.org/jira/browse/JEXL-35
>             Project: Commons JEXL
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: dion gillard
>             Fix For: 2.0
>
>         Attachments: JEXL-35.patch
>
>
> Which classes should be public?
> Is the package structure reasonable? 
> Are classes in the right packages?
> Is it easily extensible?
> ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message