Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <754911302.1244278088065.JavaMail.jira@brutus>
Date: Sat, 6 Jun 2009 01:48:08 -0700 (PDT)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (LANG-506) Entities - missing final modifiers;
 thread-safety issues
In-Reply-To: <731622498.1242648825684.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716851#action_12716851 ] 

Henri Yandell commented on LANG-506:
------------------------------------

Planning to delete Entities.

> Entities - missing final modifiers; thread-safety issues
> --------------------------------------------------------
>
>                 Key: LANG-506
>                 URL: https://issues.apache.org/jira/browse/LANG-506
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 3.0
>
>         Attachments: entities-506-1.patch, entities-506-2.patch
>
>
> Some fields in Entities are used as constants but they are not final, so can be changed accidentally or maliciously:
> ISO8859_1_ARRAY_LENGTH
> HTML40_ARRAY_LENGTH
> Entities.map should also be final
> Entities.LookupEntityMap.LOOKUP_TABLE_SIZE should be final
> Entities.MapIntMap.mapValueToName and mapNameToValue would benefit from being made final.
> This would require a constructor to be added that can initialise the Maps.
> LookupEntityMap is not thread-safe - it creates the lookup table without synchronisation, and mutates it after initial creation.
> Entities.ArrayEntityMap.growBy should be final
> As far as possible, all instance fields to be made final.
> Patch to follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.