Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 65832 invoked from network); 10 Jun 2009 09:33:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Jun 2009 09:33:22 -0000 Received: (qmail 5121 invoked by uid 500); 10 Jun 2009 09:33:32 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 5041 invoked by uid 500); 10 Jun 2009 09:33:32 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 4996 invoked by uid 99); 10 Jun 2009 09:33:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2009 09:33:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2009 09:33:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 46EA6234C1E6 for ; Wed, 10 Jun 2009 02:33:08 -0700 (PDT) Message-ID: <1470170669.1244626388289.JavaMail.jira@brutus> Date: Wed, 10 Jun 2009 02:33:08 -0700 (PDT) From: "Niall Pemberton (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (BEANUTILS-112) [beanutils] defaultTransformers is public in BeanMap class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BEANUTILS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated BEANUTILS-112: -------------------------------------- Fix Version/s: (was: 1.8.0) LATER THAN 1.8.0 > [beanutils] defaultTransformers is public in BeanMap class > ---------------------------------------------------------- > > Key: BEANUTILS-112 > URL: https://issues.apache.org/jira/browse/BEANUTILS-112 > Project: Commons BeanUtils > Issue Type: Bug > Components: Bean-Collections > Affects Versions: 1.6 > Environment: Operating System: other > Platform: Other > Reporter: Simon Kitching > Assignee: Niall Pemberton > Fix For: LATER THAN 1.8.1 > > > The BeanMap class in the "optional" section has: > public static HashMap defaultTransformers = new HashMap(); > I think this is a *really* bad idea. > Firstly, because it's static, various parts of an application can interact in > unexpected ways. For example, some library your code is calling might, > unexpectedly, add a transformer to the default transformers causing surprising > effects. > That's even more interesting if the library (commons-collections or > commons-beanutils) is deployed via a shared webapp in a container. In that case, > one webapp can have side-effects on other webapps. > And because it's a public member, there is no way to control access to this field. > This class was in commons-collections since 1.0. It was copied into > commons-beanutils before the 1.7.0 release, and deprecated in commons-collections. > This class is only in the "optional" section, and is not used by the core > beanutils code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.