commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siegfried Goeschl (JIRA)" <j...@apache.org>
Subject [jira] Commented: (EXEC-40) NPE in DefaultExecutor.setExitValues()
Date Tue, 23 Jun 2009 06:37:07 GMT

    [ https://issues.apache.org/jira/browse/EXEC-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722983#action_12722983
] 

Siegfried Goeschl commented on EXEC-40:
---------------------------------------

That is a bit embarrasing - introduced that when fixing Findbugs issues ... :-(

> NPE in DefaultExecutor.setExitValues()
> --------------------------------------
>
>                 Key: EXEC-40
>                 URL: https://issues.apache.org/jira/browse/EXEC-40
>             Project: Commons Exec
>          Issue Type: Bug
>         Environment: Ubuntu Linux, Sun Java 1.6.0_13
>            Reporter: Peter Henderson
>            Assignee: Siegfried Goeschl
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The setExitValues() of DefaultExecutor does not throws a NPE when passed a null argument.
> The documentation says passing a null should disable exit value checking.
> Solution, modify the body to correctly handle nulls.
>     public void setExitValues(final int[] values) {
> 	if (values==null) {
>             this.extiValues = null;
> 	} else {
>             this.exitValues = (int[]) values.clone();
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message