commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-505) Rewrite StringEscapeUtils
Date Sun, 14 Jun 2009 08:10:07 GMT

    [ https://issues.apache.org/jira/browse/LANG-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719235#action_12719235
] 

Henri Yandell commented on LANG-505:
------------------------------------

Also needs some potential deleting (RegexpReplacer may not be worth having as it's not used),
renaming of files and methods as we dicker design, refactoring - for example so that people
don't get the EntityArray.BASIC_ESCAPE String[][] but instead get LookupTranslator objects
such as Escapers.BASIC_XML and Unescapers.BASIC_XML.

> Rewrite StringEscapeUtils
> -------------------------
>
>                 Key: LANG-505
>                 URL: https://issues.apache.org/jira/browse/LANG-505
>             Project: Commons Lang
>          Issue Type: Task
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>         Attachments: LANG-505.diff, LANG-505.diff
>
>
> I think StringEscapeUtils needs a strong rewrite. For each escape method (and unescape)
there tend to be three or four types of escaping happening. So not being able to define which
set of three or four apply is a pain point (and cause of bug reports due to different desired
features).
> We should be offering basic functionality, but also allowing people to say "escape(Escapers.BASIC_XML,
Escapers.LOW_UNICODE, Escapers.HIGH_UNICODE)".
> Also should delete escapeSql; it's a bad one imo. Dangerous in that it will lead people
to not use PreparedStatement and given it only escapes ', it's not much use. Especially as
different dialects escape that in different ways.
> Opening this ticket for discussion. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message