commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DBCP-258) [PATCH] ManualPoolingDriverExample - more direct construction of driver and minor comment fix
Date Sun, 21 Jun 2009 17:58:07 GMT

     [ https://issues.apache.org/jira/browse/DBCP-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Thomas resolved DBCP-258.
------------------------------

    Resolution: Fixed

Thanks for the patch.
I fixed the missing back slashes but left the code as is as I can see advantages to both ways
of getting the driver.

The fixed docs will be in 1.3 onwards.

> [PATCH] ManualPoolingDriverExample - more direct construction of driver and minor comment
fix
> ---------------------------------------------------------------------------------------------
>
>                 Key: DBCP-258
>                 URL: https://issues.apache.org/jira/browse/DBCP-258
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.2.2
>            Reporter: Peter Michaux
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: ManualPoolingDriverExamplePatch.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> This example has a very indirect way of registering the driver and getting it from the
DriverManager.
>   Class.forName("org.apache.commons.dbcp.PoolingDriver");
>   PoolingDriver driver = (PoolingDriver) DriverManager.getDriver("jdbc:apache:commons:dbcp:");
> It is much more direct and clearer to do the following
>   PoolingDriver driver = new PoolingDriver();
>   DriverManager.registerDriver(driver);
> -------
> There were some missing backslashes in the comments about running the example

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message