commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Einar M R Rosenvinge (JIRA)" <>
Subject [jira] Commented: (CLI-185) Commons CLI incorrectly stripping leading and trailing quotes
Date Tue, 16 Jun 2009 06:37:08 GMT


Einar M R Rosenvinge commented on CLI-185:

It seems that BugCLI148Test.test2() relies on double quotes to parse this as a value and not
an argument. Fine, but then it should *not* automagically remove the quotes; that should be
left for the user and this should be documented as a known issue. The workaround is bad, bad,

The proper fix for CLI-148 is of course to actually support command lines like program -arg
-val, where 'arg' is the name of the argument and '-val' is the actual value. I do understand,
however, that this is a lot more work to implement.

> Commons CLI incorrectly stripping leading and trailing quotes
> -------------------------------------------------------------
>                 Key: CLI-185
>                 URL:
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 1.1, 1.2
>         Environment: Darwin dator 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17
PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386
> GNU bash, version 3.2.17(1)-release (i386-apple-darwin9.0)
> and
> Linux build-einarmr 2.6.9-023stab048.4-smp #1 SMP Fri Jul 11 18:50:44 MSD 2008 x86_64
x86_64 x86_64 GNU/Linux
> GNU bash, version 3.00.15(1)-release (x86_64-redhat-linux-gnu)
>            Reporter: Einar M R Rosenvinge
>             Fix For: 1.3
> org.apache.commons.cli.Parser.processArgs() calls Util.stripLeadingAndTrailingQuotes()
for all argument values. IMHO this is incorrect and totally broken.
> It is trivial to create a simple test for this. Output:
>     $ java -cp target/clitest.jar Clitest --balloo "this is a \"test\""
>     Value of argument balloo is 'this is a "test'.
> The argument 'balloo' should indeed keep its trailing double quote. It is what the shell
gives it, so don't try to do something clever to it.
> The offending code was committed here:
> and has been there for more than 6 years (!). Why was this committed in the first place?
> The fix is trivial, just get rid of Util.stripLeadingAndTrailingQuotes(), and consequently
avoid calling it from Parser.processArgs().

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message