Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1483183329.1241703150807.JavaMail.jira@brutus>
Date: Thu, 7 May 2009 06:32:30 -0700 (PDT)
From: "Marek Zawirski (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (VFS-253) AbstractFileObject: wrong
 synchronization of content-related code
In-Reply-To: <895195014.1241702790582.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/VFS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706885#action_12706885 ] 

Marek Zawirski commented on VFS-253:
------------------------------------

{{DefaultFileContent}} seems to be designed to work with ThreadLocal instances, but have some methods dealing with global state, like {{isOpenGlobal()}}. Iif it gonna be closed globally it probably miss some {{closeGlobal()}} method or it should be closed only for calling thread in {{AbstractFileObject#close()}}.

> AbstractFileObject: wrong synchronization of content-related code
> -----------------------------------------------------------------
>
>                 Key: VFS-253
>                 URL: https://issues.apache.org/jira/browse/VFS-253
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Marek Zawirski
>
> Creating content through {{AbstractFileObject#getContent()}} and {{DefaultFileContent}} itself seem to be synchronized, but closing the content by {{AbstractFileObject#close()}} and checking whether it is open, by {{AbstractFileObject#isContentOpen()}} are NOT synchronized.
> Both these methods miss some lock-object. For {{close()}} it may result in severe race condition in case of {{FileObject}} shared across more than one thread.
> BTW, thead-safeness of important VFS classes/interfaces like {{FileObject}} is not documented in javadoc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.