commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COLLECTIONS-317) AbstractHashedMap(Map map) constructor calls overridable non-final method
Date Wed, 20 May 2009 04:30:45 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed COLLECTIONS-317.
-------------------------------------

    Resolution: Fixed

svn ci -m "Refactoring putAll to _putAll so the constructor can call the copying in code without
running through a subclass' implementation of putAll. Reported in COLLECTIONS-317" src/

Sending        src/java/org/apache/commons/collections/map/AbstractHashedMap.java
Transmitting file data .
Committed revision 776542.

> AbstractHashedMap(Map map) constructor calls overridable non-final method
> -------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-317
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-317
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.3
>
>
> The constructor AbstractHashedMap(Map map) calls the public non-final method putAll()
from the same class.
> This is likely to cause problems if the method is ever overridden, as the parent may
not have been completely initialised when the sub-class method is invoked. 
> Possible solution: extract the code into a common private method. Or make the method
final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message