commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (IO-206) ProxyInputStream: misleading parameter names
Date Mon, 18 May 2009 19:41:45 GMT

     [ https://issues.apache.org/jira/browse/IO-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Niall Pemberton resolved IO-206.
--------------------------------

    Resolution: Fixed
      Assignee: Niall Pemberton

Fixed, thanks for the patch

http://svn.apache.org/viewvc?view=rev&revision=776062


> ProxyInputStream: misleading parameter names
> --------------------------------------------
>
>                 Key: IO-206
>                 URL: https://issues.apache.org/jira/browse/IO-206
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Streams/Writers
>    Affects Versions: 2.0
>            Reporter: Jeremias Maerki
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: IO-206-ProxyInputStream-Param-Fix.diff
>
>
> ProxyInputStream has a the following method signatures:
> - public int read(byte[] bts, int st, int end)
> - public void mark(int idx)
> But they should be:
> - public int read(byte[] bts, int off, int length)
> - public void mark(int readlimit)
> Especially the "end" parameter could be misinterpreted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message