Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 20025 invoked from network); 23 Apr 2009 05:35:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Apr 2009 05:35:11 -0000 Received: (qmail 54553 invoked by uid 500); 23 Apr 2009 05:35:10 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 54450 invoked by uid 500); 23 Apr 2009 05:35:10 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 54440 invoked by uid 99); 23 Apr 2009 05:35:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2009 05:35:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2009 05:35:08 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 74DA0234C003 for ; Wed, 22 Apr 2009 22:34:47 -0700 (PDT) Message-ID: <470463633.1240464887463.JavaMail.jira@brutus> Date: Wed, 22 Apr 2009 22:34:47 -0700 (PDT) From: "Christian Grobmeier (JIRA)" To: issues@commons.apache.org Subject: [jira] Resolved: (COMPRESS-64) Are the public finish() methods ArchiveOutputStream implementations necessary and safe? In-Reply-To: <187108265.1238249630771.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COMPRESS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved COMPRESS-64. ----------------------------------------- Resolution: Fixed I don't see an elegant way to enforce this in the abstract class without increasing complexity. I think subclasses should care themself to implement that function. Since behaviour is consistent, Issue is resolved. If some think that the functionality should go to the abstract classes, please reopen and discuss your proposal on the dev list :-) > Are the public finish() methods ArchiveOutputStream implementations necessary and safe? > --------------------------------------------------------------------------------------- > > Key: COMPRESS-64 > URL: https://issues.apache.org/jira/browse/COMPRESS-64 > Project: Commons Compress > Issue Type: Bug > Affects Versions: 1.0 > Reporter: Sebb > Fix For: 1.0 > > > Some of the ArchiveOutputStream implementations have public finish() methods. These are currently only called from the close() methods. > Seems to me that there is no need to allow the finish() methods to be called externally, and the user can corrupt the output if they do. > Surely the close() method is all that is needed? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.