commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (NET-269) Remove semi-redundant check in SubnetUtils.calculate()
Date Sat, 04 Apr 2009 23:07:12 GMT
Remove semi-redundant check in SubnetUtils.calculate()
------------------------------------------------------

                 Key: NET-269
                 URL: https://issues.apache.org/jira/browse/NET-269
             Project: Commons Net
          Issue Type: Improvement
    Affects Versions: 2.0
            Reporter: Sebb
            Priority: Minor


Remove semi-redundant check in SubnetUtils.calculate():

As far as I can tell, the line

     rangeCheck(pop(netmask),0, NBITS);

in the calculate method can never fail the NBITS max bound, as the code has already checked
for NBITS-1.

It will trap a mask with 0 bits - but then why not reject that earlier when checking cidrPart?

Seems wasteful to create pack and unpack the mask just to check for 0.

It's also confusing to reject 32 bits before creating the mask, and then "allow" it later.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message