commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (COMPRESS-64) Are the public finish() methods ArchiveOutputStream implementations necessary and safe?
Date Thu, 23 Apr 2009 05:34:47 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christian Grobmeier resolved COMPRESS-64.
-----------------------------------------

    Resolution: Fixed

I don't see an elegant way to enforce this in the abstract class without increasing complexity.
I think subclasses should care themself to implement that function. Since behaviour is consistent,
Issue is resolved. If some think that the functionality should go to the abstract classes,
please reopen and discuss your proposal on the dev list :-)

> Are the public finish() methods ArchiveOutputStream implementations necessary and safe?
> ---------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-64
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-64
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>             Fix For: 1.0
>
>
> Some of the ArchiveOutputStream implementations have public finish() methods. These are
currently only called from the close() methods.
> Seems to me that there is no need to allow the finish() methods to be called externally,
and the user can corrupt the output if they do.
> Surely the close() method is all that is needed?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message