commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (COMPRESS-60) ChangeSet does not synchronise whilst using the Iterator
Date Thu, 09 Apr 2009 11:19:13 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christian Grobmeier resolved COMPRESS-60.
-----------------------------------------

    Resolution: Fixed

Issue resolved with: r763604
- Extracted immutable Performer class
- added some notes on thread safety


> ChangeSet does not synchronise whilst using the Iterator
> --------------------------------------------------------
>
>                 Key: COMPRESS-60
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-60
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Christian Grobmeier
>             Fix For: 1.0
>
>
> ChangeSet does not synchronize whilst using the Iterator on the Set "changes" which is
a synchronizedSet.
> The Javadoc for Collections.synchronizedSet says: "
> ...
> It is imperative that the user manually synchronize on the returned set when iterating
over it:
> ...
> Failure to follow this advice may result in non-deterministic behavior."
> This affects the add() and perfom() methods.
> Also, the asSet() method returns a reference to the Set.  This method does not seem to
be used at present, so perhaps could be removed.
> Otherwise, it should either return a copy of the set, or the Javadoc should point out
that any iteration over the set must synchronize on the set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message