commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COMPRESS-64) Are the public finish() methods ArchiveOutputStream implementations necessary and safe?
Date Wed, 15 Apr 2009 10:42:14 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699145#action_12699145
] 

Sebb commented on COMPRESS-64:
------------------------------

Agreed - it may involve API changes.

> Are the public finish() methods ArchiveOutputStream implementations necessary and safe?
> ---------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-64
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-64
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>             Fix For: 1.0
>
>
> Some of the ArchiveOutputStream implementations have public finish() methods. These are
currently only called from the close() methods.
> Seems to me that there is no need to allow the finish() methods to be called externally,
and the user can corrupt the output if they do.
> Surely the close() method is all that is needed?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message