commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COLLECTIONS-319) IteratorUtils.getIterator(Object obj) performs redundant null check
Date Thu, 23 Apr 2009 02:45:47 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell updated COLLECTIONS-319:
--------------------------------------

    Fix Version/s:     (was: 3.4)
                   3.3

> IteratorUtils.getIterator(Object obj) performs redundant null check
> -------------------------------------------------------------------
>
>                 Key: COLLECTIONS-319
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-319
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Collection
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.3
>
>
> IteratorUtils.getIterator(Object obj) performs redundant null check:
> {code}
>         if (obj == null) {
>             return emptyIterator();            
> ...
>         } else if (obj != null && obj.getClass().isArray()) {
>             return new ArrayIterator(obj);
> {code}
> obj cannot be null at that point, so the check can be removed. 
> [This will also prevent a false positive in Eclipse which later says tha obj may be null]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message