commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COMPRESS-69) Inconsistent handling of BZ2-Header after redesign
Date Mon, 13 Apr 2009 15:23:14 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698412#action_12698412
] 

Christian Grobmeier commented on COMPRESS-69:
---------------------------------------------

Patch applied, thanks Uwe. Docs also updated.
New revision: r764503


> Inconsistent handling of BZ2-Header after redesign
> --------------------------------------------------
>
>                 Key: COMPRESS-69
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-69
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Uwe Schindler
>             Fix For: 1.0
>
>         Attachments: COMPRESS-69.patch
>
>
> I tried the current trunk of compress and tried the BZIP2-Streams. There are the following
inconsitenceis now:
> a) BZIP InputStream checks that the "BZ" header is available in the File (using this
magicChar method)
> b) BZIP OutputStream does not add the "BZ" header (it is commented out, saying that the
caller does this)
> c) The Javadocs of the input stream say, you should skip the header, which is wrong.
> d) the tests do not find these errors, as the test only compressed a file, but does not
try to decompress it or check its contents
> Before the redesign commit, the handling of headers was consistent (both streams used
it). The BZ Headers should be added to the Streams, as this would be consistent with GZIP
(where the headers are automatically added, too).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message