Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <830924352.1237998414681.JavaMail.jira@brutus>
Date: Wed, 25 Mar 2009 09:26:54 -0700 (PDT)
From: "Laszlo Sas (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (JCI-58) EclipseJavaCompiler fails to close
 inputstream
In-Reply-To: <1910495500.1228277324362.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCI-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689149#action_12689149 ] 

Laszlo Sas commented on JCI-58:
-------------------------------

On Windows it's a critical bug. The memory leaks.
Thanks for the fix.

> EclipseJavaCompiler fails to close inputstream
> ----------------------------------------------
>
>                 Key: JCI-58
>                 URL: https://issues.apache.org/jira/browse/JCI-58
>             Project: Commons JCI
>          Issue Type: Bug
>          Components: compiler eclipse
>    Affects Versions: 1.1
>         Environment: Java 1.5, WinXP
>            Reporter: Michael Gannon
>
> The method isPackage(final String pClaszzName) calls classLoader.getResourceAsStream() but fails to close the stream if it is opened successfully. On Windows this means all other file access to this file is not permitted. The inputstream should be closed. Here is a replacement method:
>             private boolean isPackage( final String pClazzName ) {
>                 final InputStream is = pClassLoader.getResourceAsStream(ConversionUtils.convertClassToResourcePath(pClazzName));
>                 if (is != null) {
>                     log.debug("found the class for " + pClazzName + "- no package");
>                     try {
>                         is.close();
>                     } catch (final IOException ie) {
>                         log.error("could not close input stream", ie);
>                     } 
>                     return false;
>                 }
>                 // FIXME: this should not be tied to the extension
>                 final String source = pClazzName.replace('.', '/') + ".java";
>                 if (pReader.isAvailable(source)) {
>                     log.debug("found the source " + source + " for " + pClazzName + " - no package ");
>                     return false;
>                 }
>                 return true;
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.