Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 59415 invoked from network); 17 Mar 2009 20:56:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2009 20:56:13 -0000 Received: (qmail 20477 invoked by uid 500); 17 Mar 2009 20:56:11 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 20397 invoked by uid 500); 17 Mar 2009 20:56:11 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 20386 invoked by uid 99); 17 Mar 2009 20:56:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 13:56:11 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 20:56:10 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B6DA4234C045 for ; Tue, 17 Mar 2009 13:55:50 -0700 (PDT) Message-ID: <1654488184.1237323350747.JavaMail.jira@brutus> Date: Tue, 17 Mar 2009 13:55:50 -0700 (PDT) From: "Sebb (JIRA)" To: issues@commons.apache.org Subject: [jira] Resolved: (LANG-369) ExceptionUtils not thread-safe In-Reply-To: <980491.1193765870855.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved LANG-369. ----------------------- Resolution: Fixed Applied patch: URL: http://svn.apache.org/viewvc?rev=755391&view=rev Log: LANG-369 - must use fixed object as lock target > ExceptionUtils not thread-safe > ------------------------------ > > Key: LANG-369 > URL: https://issues.apache.org/jira/browse/LANG-369 > Project: Commons Lang > Issue Type: Bug > Reporter: Sebb > Fix For: 3.0, 2.x > > Attachments: LANG-369-2.patch, LANG-369.patch > > > The ExceptionUtils class does not appear to be thread-safe: > - CAUSE_METHOD_NAMES is not final, so may not be visible to all threads > - addCauseMethodName() and removeCauseMethodName() can update CAUSE_METHOD_NAMES but are not synch. > - all accesses to CAUSE_METHOD_NAMES probably need to be synchronised > The documentation does not state whether or not the class is thread-safe, but given that it only has static methods it does not make any sense unless it is thread-safe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.