commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (SANDBOX-297) AbstractTestCase.createArchive method appears to use incorrect file size - cut and paste error?
Date Wed, 04 Mar 2009 13:45:56 GMT
AbstractTestCase.createArchive method appears to use incorrect file size - cut and paste error?
-----------------------------------------------------------------------------------------------

                 Key: SANDBOX-297
                 URL: https://issues.apache.org/jira/browse/SANDBOX-297
             Project: Commons Sandbox
          Issue Type: Bug
          Components: Compress
            Reporter: Sebb
            Priority: Minor


The createArchive() method has the following code:
{code}
ZipArchiveEntry entry = new ZipArchiveEntry("testdata/test1.xml");
entry.setSize(file1.length());
out.putArchiveEntry(entry);
IOUtils.copy(new FileInputStream(file1), out);
out.closeArchiveEntry();

entry = new ZipArchiveEntry("testdata/test2.xml");
entry.setSize(file1.length());     // <== should this be file2.length?
out.putArchiveEntry(entry);
IOUtils.copy(new FileInputStream(file2), out);
out.closeArchiveEntry();
{code}

This looks a bit odd, as the setSize() parameter does not agree with the copy() parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message