commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schaible (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-332) EqualsBuilder to alternatively use method properties
Date Mon, 02 Mar 2009 07:12:12 GMT

    [ https://issues.apache.org/jira/browse/LANG-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677909#action_12677909
] 

Joerg Schaible commented on LANG-332:
-------------------------------------

I am quite sure, that we break a lot of code if we change the behavior of this method. However,
it would be really nice if we had both - ReflectionEqualsBuilder and JavaBeanEqualsBuilder.
It simply depends on the situation where the functionality is used.

> EqualsBuilder to alternatively use method properties
> ----------------------------------------------------
>
>                 Key: LANG-332
>                 URL: https://issues.apache.org/jira/browse/LANG-332
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 2.3
>            Reporter: Paul Benedict
>             Fix For: 3.0
>
>
> While it is very nice reflection can be used to build a nice equals method, the strategy
to focus on private properties is non-negotiable. This strategy is incompatible with CGLIB
proxies which rely on method invocations to delegate to the properties of the inner target.
I would prefer a switch to dynamically invoke public get* methods over direct property access.
> PS: Same thoughts on ReflectionToStringBuilder and HashCodeBuilder

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message