commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (COMPRESS-55) CpioArchiveEntry ignores invalid modes
Date Thu, 26 Mar 2009 13:14:57 GMT
CpioArchiveEntry ignores invalid modes
--------------------------------------

                 Key: COMPRESS-55
                 URL: https://issues.apache.org/jira/browse/COMPRESS-55
             Project: Commons Compress
          Issue Type: Bug
            Reporter: Sebb


CpioArchiveEntry has the following code:
{code}
        default:
            // FIXME: testCpioUnarchive fails if I change the line to
            // actually throw the excpetion
            new IllegalArgumentException("Unknown mode (full mode: " + mode
                    + ", masked mode: " + (mode & S_IFMT));
        }
{code}
As the comment says, rejecting invalid modes causes test failures.

These appear to be caused by the code

{bq}        this.cpioEntry.setMode(0);

in the method CpioArchiveOutputStream.finish()

Is a mode of 0 allowed? If so, then setMode needs to allow it, otherwise the method call needs
to change to something else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message