commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VFS-191) Bad integer comparison in CBZip2InputStream
Date Tue, 17 Mar 2009 15:56:50 GMT

    [ https://issues.apache.org/jira/browse/VFS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682704#action_12682704
] 

Sebb commented on VFS-191:
--------------------------

The code was unnecessarily using a char, so changed to use int.

commit -m "VFS-191 - replace char by int as a work variable to allow compare with -1"
    Committed revision 755291.

> Bad integer comparison in CBZip2InputStream
> -------------------------------------------
>
>                 Key: VFS-191
>                 URL: https://issues.apache.org/jira/browse/VFS-191
>             Project: Commons VFS
>          Issue Type: Bug
>         Environment: Fortify
>            Reporter: Henri Yandell
>             Fix For: 1.1
>
>
> There are three places where 'thech' (twice) and 'ch' (once) are compared to -1; when
a char value should never be -1. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message