commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (CODEC-72) Soundex and RefinedSoundex issues with character arrays
Date Tue, 24 Mar 2009 07:19:50 GMT

     [ https://issues.apache.org/jira/browse/CODEC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed CODEC-72.
------------------------------

    Resolution: Fixed

svn ci -m "Applying sebb's patch from CODEC-72 - fixing the char[] API of Soundex/RefinedSoundex,
which shouldn't be used externally as they are the defaults. He's replaced them with Strings
for the external use and copying of inputted char[]s" 

src/test/org/apache/commons/codec/language/RefinedSoundexTest.java 
src/test/org/apache/commons/codec/language/SoundexTest.java 
src/java/org/apache/commons/codec/language/RefinedSoundex.java 
src/java/org/apache/commons/codec/language/Soundex.java

Sending        src/java/org/apache/commons/codec/language/RefinedSoundex.java
Sending        src/java/org/apache/commons/codec/language/Soundex.java
Sending        src/test/org/apache/commons/codec/language/RefinedSoundexTest.java
Sending        src/test/org/apache/commons/codec/language/SoundexTest.java
Transmitting file data ....
Committed revision 757676.

> Soundex and RefinedSoundex issues with character arrays
> -------------------------------------------------------
>
>                 Key: CODEC-72
>                 URL: https://issues.apache.org/jira/browse/CODEC-72
>             Project: Commons Codec
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: soundex.patch
>
>
> Soundex and RefinedSoundex both have public US_ENGLISH_MAPPING char arrays. These don't
appear to be used externally, so should be made private - or at least package protected.
> Also, the class constructors store externally mutable char arrays; it would be better
if these were copied.
> Patch to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message