commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <>
Subject [jira] Commented: (MATH-207) Implementation of GeneticAlgorithm.nextGeneration() is wrong
Date Thu, 19 Mar 2009 02:01:51 GMT


Phil Steitz commented on MATH-207:

Sorry for delay in reviewing these patches.  I like both the implementation (David's first
patch) and the API improvements and will apply them both if I can get answers to the following.

1) David - pls confirm that you can grant the code in your patch.  It is a borderline case
whether or not we need a code grant.  Given that it just implements the commons-math ga framework,
I think it is OK to commit without a grant; but since you did not include ASL license headers
in the patch, I need you to confirm that you own the code and can freely contribute it under
the terms of the Apache Contributor License Agreement.  If you don't mind, it would be good
to file a CLA.

2) David's patch looks like it has some JDK 1.6 dependencies.  Math 2.0 targets 1.5+, so these
need to be removed.  I can do this; but a revised patch with these removed and ASL headers
would be appreciated.

3) Ben - why expose fields as protected?  

Thanks for the patches!

> Implementation of GeneticAlgorithm.nextGeneration() is wrong
> ------------------------------------------------------------
>                 Key: MATH-207
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: David Stefka
>            Assignee: Phil Steitz
>             Fix For: 2.0
>         Attachments: geneticalgorithm.patch,, patch
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
> The implementation of GeneticAlgorithm.nextGeneration() is wrong, since the only way
how a Chromosome can get into the new generation is by mutation. 
> Enclosed, I am sending a patch for this.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message