commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COMPRESS-11) Ar doesn't delete correct
Date Sat, 28 Mar 2009 14:05:50 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693441#action_12693441
] 

Sebb commented on COMPRESS-11:
------------------------------

The method public int read(byte b[]) could now be deleted, as it now just does what the parent
method does.

The method read() does not do any checking for end of entry; probably best to replace it with
a call to read(byte[] b, int off, int len);

> Ar doesn't delete correct
> -------------------------
>
>                 Key: COMPRESS-11
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-11
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Christian Grobmeier
>            Assignee: Torsten Curdt
>             Fix For: 1.0
>
>         Attachments: patch-ar-improvement.txt
>
>
> When working on the Testcases i figured out that a deletion from an Ar Archive is not
as successful as it look at first glance.
> For example: my bla.ar file contains test1.xml and test2.xml. I delete test2.xml
> The "getNextEntry" Method just delivers test1.xml. Looks correct.
> But checking the result file at commandline brings the following:
> $> ar -t /tmp/dir26673/bla.ar
> test1.xml
> test2.xml
> vi shows me that there is still the test2.xml entry in the archive,
> even when getNextEntry returns null.
> Deleting test2.xml and adding test.txt afterward brings the following:
> $> ar -t /tmp/dir24825/bla.ar
> test.txt
> ar: /tmp/dir24825/bla.ar: Inappropriate file type or format

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message